Skip to content

Add option to remove Pod name prefix in resulting container name #27302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2025
Merged

Add option to remove Pod name prefix in resulting container name #27302

merged 3 commits into from
Oct 20, 2025
+58 −1

Conversation

arsenalzp
Copy link
Contributor

@arsenalzp arsenalzp commented Oct 15, 2025 •
edited by mheon
Loading

This PR is bringing capability to remove Pod name prefix from resulting container name.
Close #26396

If no objections for my solution then I will create test case!

Does this PR introduce a user-facing change?

No

Added a new option, `--no-pod-prefix`, to the `podman kube play` command to disable prefixing container names with the pod name. Please note this can cause pods to fail to start if the pod shares a name with a container.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Oct 15, 2025
@packit-as-a-service Packit-as-a-Service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Honny1
Honny1 reviewed Oct 16, 2025
View reviewed changes
Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance, the changes look good. However, tests for the new functionality are missing.

@arsenalzp
Copy link
Contributor Author

At first glance, the changes look good. However, tests for the new functionality are missing.

Hello,
Thank you for feedback.
Yes, as I mentioned in the initial message - test will be created once solution approach is accepted by reviewers.

Honny1
Honny1 reviewed Oct 17, 2025
View reviewed changes
Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the CI results and pointed out the problematic parts.

mheon
mheon reviewed Oct 17, 2025
View reviewed changes
@mheon
Copy link
Member

mheon commented Oct 17, 2025

I have a nit on documentation, but the code LGTM
/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arsenalzp, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Oct 17, 2025
@mheon
Copy link
Member

mheon commented Oct 17, 2025

Added a release note

@arsenalzp arsenalzp force-pushed the podman_26396 branch 2 times, most recently from 99d6b3f to 37928d5 Compare October 17, 2025 22:36
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Oct 17, 2025
@arsenalzp
fix remote command parameters
bb4fa06 
Signed-off-by: Oleksandr Krutko <[email protected]>
@arsenalzp arsenalzp requested review from Honny1 and mheon October 17, 2025 23:10
@arsenalzp
Copy link
Contributor Author

I have a nit on documentation, but the code LGTM /approve

I took into account your remark, it has been just fixed.

Honny1
Honny1 reviewed Oct 20, 2025
View reviewed changes
Copy link
Member

@Honny1 Honny1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@mheon
Copy link
Member

mheon commented Oct 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 9146ef6 into containers:main Oct 20, 2025
81 checks passed
@arsenalzp arsenalzp deleted the podman_26396 branch October 21, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mheon mheon Awaiting requested review from mheon

1 more reviewer

@Honny1 Honny1 Honny1 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mheon mheon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Option to deactivate pod-name prefix in podman play kube

3 participants

@arsenalzp @mheon @Honny1