feat(quadlet: kube): support multiple Yaml entries #27340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm OK with this change. |
Honny1
reviewed
Oct 22, 2025
fixes containers#26274 Signed-off-by: axel7083 <[email protected]>
axel7083
force-pushed
the
feature/quadlet/kube-support-multiple-yaml
branch
from
cd39793 to
8e013c0
Compare
ygalblum
reviewed
Oct 22, 2025
| @@ -0,0 +1,4 @@ | |||
| [Kube] | |||
There was a problem hiding this comment.
This file is missing:
## assert-failed
## assert-stderr-contains <The expected error message>
There was a problem hiding this comment.
Thanks! I was kinda lost 😿 !
Signed-off-by: axel7083 <[email protected]>
|
It looks like the CI failure was just a flaky test. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axel7083, Honny1, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #26274
Does this PR introduce a user-facing change?
Following #27292, the podman kube play/down command supports multiple files as argument. (Thanks again @Honny1 for your amazing work getting this fixed and merged).
However, the issue #26274 originally targeted the Kube Quadlet, and I explained that this is a two steps process
The first step has been completed by #27292 and this is the second.