DX - 3258 - Added Variant support in Audit plugin to check for publish_details and references #2045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aman19K
requested changes
Aug 6, 2025
| @@ -568,6 +576,11 @@ export abstract class AuditBaseCommand extends BaseCommand<typeof AuditBaseComma | |||
| row['Fix status'] = row.fixStatus; | |||
| } | |||
|
|
|||
| // Handle variant flag for entries | |||
| if ('is_variant' in issue) { | |||
There was a problem hiding this comment.
@cs-raj , can we add is_variant in constant files or somewhere else? So that we can use the variable in test cases as well.
| @@ -1,4 +1,7 @@ | |||
| import map from 'lodash/map'; | |||
There was a problem hiding this comment.
@cs-raj , try to use import map from 'lodash/map';
Comment on lines
+5
to
+15
| export class VariantLogger implements IVariantLogger { | ||
| constructor(private readonly log: LogFn) {} | ||
|
|
||
| logError(message: string, args: Record<string, string>): void { | ||
| this.log($t(message, args), 'error'); | ||
| } | ||
|
|
||
| logInfo(message: string, args: Record<string, string>): void { | ||
| this.log($t(message, args), 'info'); | ||
| } | ||
| } |
There was a problem hiding this comment.
@cs-raj , why have you added separate logger for variant? We can use existing audit log file
| private isValidVariantEntry(entry: unknown): entry is VariantEntry { | ||
| if (!entry || typeof entry !== 'object') return false; | ||
|
|
||
| const e = entry as Record<string, unknown>; |
There was a problem hiding this comment.
@cs-raj , instead of e variable can you use meaningful name ?
| if (Array.isArray(value)) { | ||
| // Check each item in array for references | ||
| for (const item of value) { | ||
| if (item && typeof item === 'object' && item.uid && item._content_type_uid) { |
There was a problem hiding this comment.
@cs-raj , use optional chaining here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version bump: 1.14.0 -> 1.15.0