-
Notifications
You must be signed in to change notification settings - Fork 1
Fix/dx 3678 improve tests #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e proper functionality and edge case handling.
…t, CSHttpConnection, and CSUtil classes to ensure proper functionality and edge case handling.
…es to ensure proper functionality and edge case handling.
…nality, including fetch methods, parameter handling, and date getters to ensure robust error handling and functionality.
…g on cache handling, error scenarios, and reflection-based method invocations to ensure robust functionality and error management.
…handling in AssetLibrary to ensure robust error management and functionality across various scenarios.
…ing options, finding titles, and handling various node types to ensure robust functionality and high test coverage.
… header management, data retrieval, and various methods to ensure robust functionality and high test coverage.
…ing reflection to validate exception handling, header management, cache operations, and network fetching to ensure robust functionality and error management.
…obalField, and related classes, focusing on various configurations, header management, and edge case handling to ensure robust functionality and high test coverage.
…ge, LanguageCode, and LanguageCodeComprehensive classes, focusing on various data types, exception handling, and ensuring robust functionality and high test coverage.
…vanced, and QueryComprehensive classes, focusing on various constructors, methods, and edge cases to ensure robust functionality and high test coverage.
…e methods, focusing on various query operations, edge cases, and reflection-based method invocations to ensure robust functionality and high test coverage.
…, and SDKConstant classes, focusing on various methods, constants, and edge cases to ensure robust functionality and high test coverage.
…, covering various methods, edge cases, and header management to ensure robust functionality and high test coverage.
…n and constant values to ensure robust functionality and high test coverage.
…liminating redundant tests for constant values and naming conventions to enhance maintainability.
… and always methods to ensure correct behavior and high test coverage.
…fying callback behavior and constructor functionality to ensure robust implementation and high test coverage.
…Request, verifying JSON parsing behavior for valid and invalid responses to enhance test coverage.
…and always methods to ensure correct behavior and enhance test coverage.
…nd always methods to ensure correct behavior and enhance test coverage.
…and handling of empty directories to ensure correct cache management behavior and enhance test coverage.
… and always methods to ensure correct behavior and enhance test coverage.
…estFailed and onRequestFinished methods, including error handling and response verification for various scenarios.
…ding network connectivity changes, handling of offline calls, and edge cases to ensure robust behavior and enhance test coverage.
…enhance test coverage reporting with new tasks for unit and instrumentation tests.
…cenarios for queries, entries, assets, and global fields to enhance test coverage and ensure correct behavior.
…xception handling tests in TestAssetLibraryAdvanced. Enhance TestClearCache with new tests for cache file management, ensuring proper deletion of old files and retention of recent files, while handling invalid JSON gracefully.
…enarios including all fields, pagination and sync tokens, and null input handling to enhance test coverage and ensure correct behavior.
…cenarios including header management, entry and query creation, and special character handling to ensure robust behavior and correct functionality.
… for JSON to HTML transformation, including handling of embedded items, reference nodes, and various entry types to ensure correct rendering behavior.
… onRequestFail methods, ensuring correct handling of responses and errors, and testing the always callable functionality to enhance test coverage.
…eration of built errors with null and custom messages, as well as known error types to enhance test coverage and ensure correct error response behavior.
…l response and correct error message for network errors, enhancing error handling test coverage.
… to streamline test coverage configuration.
…gradle and introduce unit tests for SyncResultCallBack, verifying callback behavior and error handling to enhance test coverage.
…fying onRequestFinish and onRequestFail methods, ensuring correct handling of responses and errors, and testing the always callable functionality to enhance test coverage.
…SyncResultCallBack across various sync scenarios, including error handling, pagination, and multiple content types, to enhance test coverage and ensure correct callback functionality.
…e for improved code readability and formatting consistency.
… builder tests. Added assertions to verify correct query construction for various methods, including in, or, and, equalAndBelow, below, equalAbove, and above. Improved error handling tests and ensured that empty parameters do not modify the query. This update enhances test coverage and ensures accurate behavior of the Taxonomy class.
… internal constructors and introducing a helper method for creating fully-populated Entry instances. Enhanced test coverage for basic accessors, date fields, and markdown helpers, while ensuring negative cases are handled correctly. This update improves test clarity and maintainability.
…TestAssetLibraryPrivateMethods, TestCachePolicy, TestCSConnectionRequestMocked, TestLanguageCodeComprehensive, TestResponseTypeEnum, TestStackHeaderHandling, and TestStackSyncCallbacks. This cleanup enhances maintainability and reduces redundancy in the codebase.
reeshika-h
previously approved these changes
Nov 21, 2025
Contributor
reeshika-h
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…ltCallBack and Stack callback interfaces, improving test coverage configuration and maintainability.
reeshika-h
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.