Skip to content

chore: remove is too big check #6665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Jul 16, 2025

Description

Removes the item is too big check, #4790, feedback has been that it's a bit noisy
Pruning message warnings will address part of the original reason for this

Draft, looking into updating the error message etc. instead of removing


Summary by cubic

Removed the "is item too big" check from core logic and UI to reduce noise and simplify context item handling. Pruning message warnings will now handle related errors earlier.

@RomneyDa RomneyDa requested a review from a team as a code owner July 16, 2025 23:08
@RomneyDa RomneyDa requested review from tomasz-stefaniak and removed request for a team July 16, 2025 23:08
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 16, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 5 files and found no issues. Review PR in cubic.dev.

@RomneyDa RomneyDa marked this pull request as draft July 16, 2025 23:12
@bdougie
Copy link
Collaborator

bdougie commented Jul 19, 2025

I was receiving this error without much effort, @ one markdown file. Perhaps pruning or concatenating removes the need for this message moving forward?

I am all for unblocking this from the user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants