Skip to content

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Jul 17, 2025

Description

  • Only load .continuerc.json for JSON config loading
  • Remove duplicate getWorkspaceConfigs logic

Summary by cubic

Simplified workspace config loading by only reading .continuerc.json files and removing duplicate getWorkspaceConfigs logic.

  • Refactors
    • Moved workspace config file reading into a single function.
    • Removed getWorkspaceConfigs from IDE interfaces and extensions.

@RomneyDa RomneyDa requested a review from a team as a code owner July 17, 2025 14:59
@RomneyDa RomneyDa requested review from tomasz-stefaniak and removed request for a team July 17, 2025 14:59
Copy link

⚠️ Conventional Commit Format

Your latest commit message doesn't follow the conventional commit format, but this won't block your PR from being merged. We recommend downloading this extension if you are using VS Code.

Expected Format:

<type>[optional scope]: <description>

[optional body]

[optional footer(s)]

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 17, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 13 files and found no issues. Review PR in cubic.dev.

@RomneyDa RomneyDa changed the title fix: getWorkspaceConfigs improvements fix: remove getWorkspaceConfigs Jul 17, 2025
@RomneyDa RomneyDa changed the title fix: remove getWorkspaceConfigs chore: remove getWorkspaceConfigs Jul 21, 2025
Copy link
Collaborator

@tomasz-stefaniak tomasz-stefaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it when PRs remove code!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 28, 2025
@tomasz-stefaniak tomasz-stefaniak merged commit 3b61563 into main Jul 28, 2025
48 checks passed
@tomasz-stefaniak tomasz-stefaniak deleted the dallin/remove-get-configs branch July 28, 2025 20:21
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jul 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 28, 2025
@sestinj
Copy link
Contributor

sestinj commented Aug 18, 2025

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Aug 18, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants