Skip to content

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Jul 18, 2025

Description

Hotfix, os methods were being tried on the GUI and causing it not to load


Summary by cubic

Fixed a bug where terminal tool definitions used os method references instead of their values, which caused the GUI to fail loading.

@RomneyDa RomneyDa requested a review from a team as a code owner July 18, 2025 09:55
@RomneyDa RomneyDa requested review from sestinj and removed request for a team July 18, 2025 09:55
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 18, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 1 file and found no issues. Review PR in cubic.dev.

@RomneyDa RomneyDa changed the title fix: don't stringify os methods in terminal tool definition fix: invoke os methods in terminal tool definition Jul 18, 2025
@sestinj sestinj merged commit 2b04352 into main Jul 22, 2025
78 of 80 checks passed
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 22, 2025
@sestinj sestinj deleted the dallin/terminal-tool-os branch July 22, 2025 04:58
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 22, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jul 22, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2025
@sestinj
Copy link
Contributor

sestinj commented Jul 22, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Jul 24, 2025

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer released size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants