Skip to content

Conversation

uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Sep 11, 2025

Description

Close the listbox only when a click outside the listbox options is detected for AssistantAndOrg Select and Mode Select

resolves CON-3879

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

feat.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Keep Assistant/Org and Mode listboxes open until the user clicks outside; adds a shared useClickOutside hook to control closing behavior. Resolves CON-3879.

  • Bug Fixes
    • Added useClickOutside to close listboxes only on outside clicks.
    • Made ListboxOptions controlled via listboxOpen + static and refs; removed programmatic Escape close.
    • Removed onClose props and stop closing on option selection; buttons now open the listbox, and it closes only on outside click.
    • Updated navigation/actions (e.g., New Assistant, Rules) to explicitly close the listbox after handling.

@uinstinct uinstinct requested a review from a team as a code owner September 11, 2025 08:56
@uinstinct uinstinct requested review from sestinj and removed request for a team September 11, 2025 08:56
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 11, 2025
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct I think the current goal based on linear ticket is to keep the listbox open when you select an assistant

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 11, 2025
@uinstinct
Copy link
Contributor Author

uinstinct commented Sep 12, 2025

@uinstinct I think the current goal based on linear ticket is to keep the listbox open when you select an assistant

right. actually the listbox closes only when the user clicks outside of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants