chore: edit file tool improvements #7708
Open
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uinstinct
requested review from
tomasz-stefaniak
and removed request for
a team
dosubot
bot
added
the
size:S
| @@ -1103,6 +1103,7 @@ export interface Tool { | |||
| basePolicy: ToolPolicy, | |||
| parsedArgs: Record<string, unknown>, | |||
| ) => ToolPolicy; | |||
| skipToolArgsDisplay?: boolean; | |||
There was a problem hiding this comment.
I'd usually advise negative names such as 'skip', 'doNot', 'shouldNot' etc. Instead, how about 'displayToolArgs' that defaults to true? Otherwise, this may result in expressions such as !!skipToolArgsDisplay which are difficult to reason about.
| @@ -135,6 +136,7 @@ interface StyledMarkdownPreviewProps { | |||
| toolCallId?: string; | |||
| expandCodeblocks?: boolean; | |||
| collapsible?: boolean; | |||
| removePadding?: boolean; | |||
There was a problem hiding this comment.
Ditto - instead of removedPadding, you can name this padded and default it to true.
tomasz-stefaniak
requested changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the edit file tool.
resolves CON-2405
AI Code Review
@continue-general-reviewor@continue-detailed-reviewChecklist
Screen recording or screenshot
before
after
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Streamlined the Edit File tool UI and added a way for tools to hide noisy args. Also removed padding around Create/Edit file code blocks for a tighter look. Resolves CON-2405.
New Features
Bug Fixes