Skip to content

fix(cli): validate required parameters in tool call #8598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): validate required parameters in tool call #8598

wants to merge 1 commit into from
+3 −4

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Nov 5, 2025 •
edited
Loading

Description

Previously, validateToolCallArgsPresent was iterating over Tool.Parameters instead of Tool.Parameters.properites
This PR fixes that

resolves CON-4775

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

before

image

after

image

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

@uinstinct uinstinct requested a review from a team as a code owner November 5, 2025 06:07
@uinstinct uinstinct requested review from sestinj and removed request for a team November 5, 2025 06:07
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 5, 2025
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Nov 5, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@sestinj sestinj Awaiting requested review from sestinj sestinj is a code owner automatically assigned from continuedev/continue-code-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Issues and PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@uinstinct