journal: ability to set flags for journal instance #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranovegor
force-pushed
the
journal-flags
branch
from
59f8778 to
16d5271
Compare
taranovegor
force-pushed
the
journal-flags
branch
from
16d5271 to
1953a9e
Compare
Luap99
reviewed
Jul 31, 2025
| } | ||
|
|
||
| // NewJournalWithFlags return a new Journal instance pointing to the local journal | ||
| // with a list of flags indicating the scope and type of entries that will be accessed. |
There was a problem hiding this comment.
Can you document that the flag values are defined as SD_JOURNAL_FLAG_ and must be bitwise ORed
| @@ -48,6 +48,10 @@ type JournalReaderConfig struct { | |||
| // in this directory. The supplied path may be relative or absolute. | |||
| Path string | |||
|
|
|||
| // If not nil, the journal instance will point to a journal with a list | |||
| // of flags indicating the scope and type of entries that will be accessed. | |||
| Flags []int | |||
There was a problem hiding this comment.
Why this an array? Just let the caller do the bitwise OR. I think the issue is that the default flag will be 0 but ensure we know a user explicitly set the flags converting it to pointer may be enough so *int,
kolyshkin
reviewed
Aug 13, 2025
There was a problem hiding this comment.
@taranovegor please let us know if you want to keep working on this.
Yes, I will continue working on this, but I won’t be able to do it ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to merge journals, which involves using the
--mergeflag when callingjournalctl. Since I couldn't find a way to do this in the current implementation, I propose the following solution.The structure
JournalReaderConfigis augmented with a fieldFlagsthat contains an array of constants. If theFlagsarray is not empty, the methodNewJournalWithFlagsis called with the bitwise OR of the values in the array.