Skip to content

require the security token for approval. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

require the security token for approval. #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fc4059
fix missing negation
Chris--S Feb 20, 2013
f6c0e4c
Merge remote-tracking branch 'upstream/multiple_users' into multiple_…
Chris--S Feb 20, 2013
0d72a66
require the security token for approval, add it into the approval link
Chris--S Feb 20, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion action/approve.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,14 @@ function handle_io_write(Doku_Event &$event, $param) {
return;
}

if ($INPUT->has('publish_approve')) {
if (!$INPUT->has('publish_approve')) {
return;
}

if(!checkSecurityToken()){
return;
}

if (!$this->helper->canApprove()) {
msg($this->getLang('wrong permissions to approve'), -1);
return;
Expand Down
8 changes: 7 additions & 1 deletion action/banner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,14 @@ private function showApproveAction() {
}
}

$params = array(
'rev' => $REV,
'publish_approve' => 1,
'sectok' => getSecurityToken(),
);

echo '<span class="approval_action">';
echo '<a href="' . wl($ID, array('rev' => $REV, 'publish_approve'=>1)) . '">';
echo '<a href="' . wl($ID, $params) . '">';
echo $this->getLang('approve action');
echo '</a>';
echo '</span> ';
Expand Down