Skip to content

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Oct 3, 2025

Results of: go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix

Integration Tests

@torcolvin torcolvin requested review from bbrks and Copilot October 3, 2025 14:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies automated modernization fixes to the Go codebase, converting legacy patterns to more modern Go syntax. The changes are the result of running the gopls modernize tool which suggests and applies various code improvements.

Key changes include:

  • Replacing interface{} with any (Go 1.18+ alias)
  • Converting strings.Split to strings.SplitSeq for range iterations
  • Using fmt.Appendf instead of fmt.Sprintf with byte slice conversion
  • Utilizing maps.Copy for copying maps
  • Replacing numeric range loops with range-only syntax
  • Using slices.Contains for slice membership checks

Reviewed Changes

Copilot reviewed 232 out of 232 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Various Go files Replaced interface{} with any throughout the codebase
Multiple files Converted strings.Split + range to strings.SplitSeq
Several files Used fmt.Appendf(nil, ...) instead of []byte(fmt.Sprintf(...))
Multiple files Replaced manual map copying with maps.Copy
Various test files Simplified numeric range loops to range-only syntax
Handler and utility files Applied slices.Contains for slice membership checks
Comments suppressed due to low confidence (5)

bbrks
bbrks previously approved these changes Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants