fix: save cop_features bits in compiled COP structs#103
Open
fix: save cop_features bits in compiled COP structs#103
Conversation
The cop_features field was hardcoded to 0 in compiled output. This caused feature flags to be lost when the feature bundle is FEATURE_BUNDLE_CUSTOM (e.g. explicit 'use feature "say"'), since the interpreter checks cop_features.bits[] via FEATURE_IS_ENABLED_MASK only when HINT_LOCALIZE_HH is set in cop_hints. Added cop_features_bits() XS accessor to B::COP in C.xs and save_cop_features() method in COP.pm to properly serialize the cop_features struct into the generated C initializer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cop_features field was hardcoded to 0 in compiled output. This caused feature flags to be lost when the feature bundle is FEATURE_BUNDLE_CUSTOM (e.g. explicit 'use feature "say"'), since the interpreter checks cop_features.bits[] via FEATURE_IS_ENABLED_MASK only when HINT_LOCALIZE_HH is set in cop_hints.
Added cop_features_bits() XS accessor to B::COP in C.xs and save_cop_features() method in COP.pm to properly serialize the cop_features struct into the generated C initializer.