Skip to content

Conversation

@dalg24
Copy link
Member

@dalg24 dalg24 commented Nov 4, 2025

@tkoeppe tkoeppe requested a review from jwakely November 4, 2025 23:42
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 4, 2025

Please update commit messages to contain the standard "Fixes NB ..." phrase (see other commits).

Fixes US 195-313 (C++26 NB).
@dalg24 dalg24 force-pushed the atomic_ref_pointer branch from 937f0f2 to f778739 Compare November 4, 2025 23:46
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LWG determined this is editorial, because there's no T in scope here and what we care about is being able to do arithmetic on some pointer-type which requires knowing the sizeof the pointee type. The edit matches what LWG asked for.

@tkoeppe tkoeppe merged commit a1e1535 into cplusplus:main Nov 5, 2025
2 checks passed
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 5, 2025

@dalg24 Close enough :-)

@dalg24
Copy link
Member Author

dalg24 commented Nov 5, 2025

@dalg24 Close enough :-)

Yeah sorry I noticed I had the wrong message but I had another branch checked out and was planning to fix it again later.

@dalg24 dalg24 deleted the atomic_ref_pointer branch November 5, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants