Skip to content

Conversation

@hubert-reinterpretcast
Copy link
Contributor

Rephrase the definition of variant members to address the following problems with the current wording:

  • It creates a misleading reading of the "[in] addition, [ ... ]" sentence as applying only to the case where X is a union.
  • It is not phrased as complete/exhaustive.

Rephrase the definition of variant members to address the following
problems with the current wording:

- It creates a misleading reading of the "[in] addition, [ ... ]"
  sentence as applying only to the case where `X` is a union.
- It is not phrased as complete/exhaustive.
Comment on lines +3414 to +3416
The \defnx{variant members}{variant member} of a union-like class \tcode{X} are the variant
members of the anonymous union members of \tcode{X} and, if \tcode{X} is a union, the
non-static data members of \tcode{X} other than anonymous union members.
Copy link
Member

@eisenwave eisenwave Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The \defnx{variant members}{variant member} of a union-like class \tcode{X} are the variant
members of the anonymous union members of \tcode{X} and, if \tcode{X} is a union, the
non-static data members of \tcode{X} other than anonymous union members.
The \defnx{variant members}{variant member} of a union-like class \tcode{X} are
the variant members of the anonymous union members of \tcode{X}, and
if \tcode{X} is a union, the non-static data members of \tcode{X} other than anonymous union members.

If we're touching this section anyway, it seems beneficial to reflow the text so that if it was turned into bullets, we'd only need to add \items at the start of each line.

The \defnx{variant members}{variant member} of a union-like class \tcode{X} are
\begin{itemize}
\item the variant members of the anonymous union members of \tcode{X}, and
\item if \tcode{X} is a union, the non-static data members of \tcode{X} other than anonymous union members.
\end{itemize}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I don't think this paragraph is that broken though. The suggestion seems like a slight upgrade.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placement of the comma in the suggestion is less grammatical as the list is of two items and the commas are parenthetical (around the condition introduced with the "if") in nature.

@eisenwave eisenwave added the P3-Other Triaged issue not in P1 or P2 label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3-Other Triaged issue not in P1 or P2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants