Skip to content

Conversation

@eisenwave
Copy link
Member

Fixes #8474

No NB comment.
No paper tracker issue yet.

@eisenwave eisenwave added this to the post-2025-11 milestone Nov 14, 2025
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The itemdecl needs to declare k used in the itemdescr.

@eisenwave eisenwave requested a review from jwakely November 15, 2025 18:16
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought "Fixup" commits were for minor editorial corrections to the paper wording, not for cases where the pull request doesn't correctly implement the paper wording.

Anyway, this is correct now.

@eisenwave
Copy link
Member Author

I thought "Fixup" commits were for minor editorial corrections to the paper wording, not for cases where the pull request doesn't correctly implement the paper wording.

I thought so too. Then I had a conversation last motions where it was brought up that we don't want authors to force-push on these motions because it makes reviewing harder or something, so it's better to add a Fixup commit even for things that weren't proper paper applications in the first place.

To be fair, I don't think it would have killed anyone if I force-pushed this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2025-11 LWG Motion 15] P3922R1 Missing deduction guide from simd::mask to simd::vec

2 participants