validate arg indirect attribute before indexing direction array - #8850
Open
Nussu06 wants to merge 1 commit into
Open
validate arg indirect attribute before indexing direction array#8850Nussu06 wants to merge 1 commit into
Nussu06 wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| if (const char* const argIndirect = functionnode->Attribute("indirect")) { | ||
| const int indirect = strToInt<int>(argIndirect); | ||
| if (indirect < 0 || indirect >= static_cast<int>(ac.direction.size())) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadFunction writes
ac.direction[indirect]whereindirectcomes straight from theindirectattribute of an<arg>element in a--librarycfg file, with no range check, so a value likeindirect="1000000"orindirect="-5"writes outside the fixed 3-elementdirectionarray. Reject an out-of-rangeindirectwithBAD_ATTRIBUTE_VALUE, matching the bounds checkgetArgDirectionalready applies when reading the same array.