Skip to content

Bugfix/on close print dialog chrome #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Bugfix/on close print dialog chrome #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d12d19f
update webpack config for .map files
Nov 24, 2020
ef5a1f7
waiting mouseover after print dialog close
Nov 24, 2020
fff2712
other event
Nov 24, 2020
b997728
add timeout for waiting load print dialog chrome
Nov 24, 2020
ac6454c
standard fixes
Nov 25, 2020
5ac5a64
exclude changes
Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/js/functions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ export function cleanUp (params) {
if (params.showModal || params.onLoadingStart) window.URL.revokeObjectURL(params.printable)

// Run onPrintDialogClose callback
let event = 'mouseover'
let event = 'mousemove'

if (Browser.isChrome() || Browser.isFirefox()) {
if (Browser.isFirefox()) {
// Ps.: Firefox will require an extra click in the document to fire the focus event.
event = 'focus'
}
Expand All @@ -94,7 +94,12 @@ export function cleanUp (params) {
}
}

window.addEventListener(event, handler)
if (Browser.isChrome()) {
// waiting for load print dialog
setTimeout(() => { window.addEventListener(event, handler) }, 1500)
} else {
window.addEventListener(event, handler)
}
}

export function isRawHTML (raw) {
Expand Down
2 changes: 1 addition & 1 deletion webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module.exports = {
libraryTarget: 'umd',
path: path.resolve(__dirname, 'dist'),
filename: 'print.js',
sourceMapFilename: 'print.map',
sourceMapFilename: '[file].map[query]',
libraryExport: 'default'
},
module: {
Expand Down