Skip to content

Downgrade to sqlalchemy-cratedb 0.41, version 0.42 is not GA yet #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Downgrade to sqlalchemy-cratedb 0.41, version 0.42 is not GA yet #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Unreleased
- Downgraded to sqlalchemy-cratedb 0.41, version 0.42 is not GA yet

## 2025/05/12 v0.0.33
- CFR: Enhanced job statistics with optional reporting database support. Thanks, @WalBeh.
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ dependencies = [
"python-slugify<9",
"pyyaml<7",
"requests>=2.28,<3",
"sqlalchemy-cratedb>=0.42.0.dev2",
"sqlalchemy-cratedb>=0.41",
Copy link

@coderabbitai coderabbitai bot May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add an upper bound to lock dependency to 0.41.x
Currently the constraint

"sqlalchemy-cratedb>=0.41"

will allow future 0.42.x (once GA) or any higher major, potentially reintroducing unstable pre-releases or breaking changes. To explicitly block 0.42 until it’s GA and adhere to semver, consider tightening it to:

- "sqlalchemy-cratedb>=0.41",
+ "sqlalchemy-cratedb>=0.41,<0.42",
🤖 Prompt for AI Agents (early access) 
In pyproject.toml at line 113, the dependency "sqlalchemy-cratedb>=0.41" lacks
an upper bound, which may allow incompatible future versions. Update the version
constraint to "sqlalchemy-cratedb>=0.41,<0.42" to restrict it to the 0.41.x
range and prevent automatic upgrades to 0.42 or higher until they are stable.

"sqlparse<0.6",
"tqdm<5",
"typing-extensions<5; python_version<='3.7'",
Expand Down