Skip to content

Conversation

@JossDev-Morales
Copy link

@JossDev-Morales JossDev-Morales commented Apr 23, 2025

PR Title:

Fix Font Awesome script and improve meta description rendering

PR Description:

This PR addresses several issues related to the Font Awesome script and improves the conditional rendering of the meta description in the HTML. It also includes improvements to the script structure to avoid TypeScript warnings.

Changes List:

  • Fixed the crossOrigin attribute in the Font Awesome script: Updated from crossOrigin to crossorigin to ensure correct functionality.
  • Added the is:inline attribute to Google Tag Manager and Font Awesome scripts: This resolves TypeScript type errors and ensures the inline code is handled correctly.
  • Conditional rendering for metaDescription: metaDescription is now only rendered if it's present, avoiding undefined values in the HTML.

Additional Notes:

  • These changes enhance code compatibility and improve the development experience, particularly when using TypeScript.
  • Note: Please review this PR before merging to ensure no new issues are introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant