fix: streaming error handling type mismatch #292
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a type mismatch error that occurs when handling errors during streaming responses. The streaming error handlers were passing plain hashes to
ErrorMiddleware.parse_error
, butparse_error
expected Faraday response objects with abody
method.Problem
When errors occurred during streaming, the application would crash with:
Solution
ErrorResponse
struct that mimics the Faraday::Response interfacehandle_error_chunk
,handle_failed_response
,handle_error_event
) to use a newcreate_error_response
helper methodenv
parameter in streaming contextsTesting
Added tests to
spec/ruby_llm/error_handling_spec.rb
that verify:All tests pass and the streaming error handling now works consistently with regular response error handling.
🤖 Generated with Claude Code