Add ollama_api_key support for remote Ollama endpoints#612
Open
geeksilva97 wants to merge 2 commits intocrmne:mainfrom
Open
Add ollama_api_key support for remote Ollama endpoints#612geeksilva97 wants to merge 2 commits intocrmne:mainfrom
geeksilva97 wants to merge 2 commits intocrmne:mainfrom
Conversation
Superseded due to shell-escaped formatting corruption in review body.
crmne
requested changes
Feb 27, 2026
Owner
crmne
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I’m requesting changes because the repository contribution requirements for new features are not met yet:
- New features require a prior approved issue, and this PR has no linked issue (
closingIssuesReferencesis empty and the PR checklist leaves that unchecked). - The quality checklist indicates
overcommithooks were not run. Please run the configured hooks and update the checklist. - This introduces
ollama_api_keysupport, but there is no accompanying docs update (for example, indocs/_getting_started/configuration.md), and the PR checklist leaves documentation unchecked.
Please address these process requirements and re-request review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
=======================================
Coverage 80.13% 80.14%
=======================================
Files 113 113
Lines 5095 5096 +1
Branches 1307 1308 +1
=======================================
+ Hits 4083 4084 +1
Misses 1012 1012 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
Will do. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Allow callinc remote Ollama endpoints for using ollama cloud models
Type of change
Scope check
Required for new features
PRs for new features or enhancements without a prior approved issue will be closed.
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)AI-generated code