bump crossplane-runtime to v2.2.0#602
Conversation
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
d943cd8 to
9da8978
Compare
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
9da8978 to
91a316d
Compare
erhancagirici
left a comment
There was a problem hiding this comment.
@fernandezcuesta thanks for the PR! Looks good already, just some minor polishing requests:
To keep the PR scope focused, could you rebase your PR and exclude golangci-lint related changes? #576 was merged to handle changes related to linter.
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
@erhancagirici merged from main and bumped up go to the latest 1.25 minor revision. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Go toolchain version in the CI/CD configuration has been updated from 1.24 to 1.25.8, changing the GO_VERSION environment variable that is referenced throughout the CI pipeline for build and test operations. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 2 inconclusive)
✅ Passed checks (4 passed)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
erhancagirici
left a comment
There was a problem hiding this comment.
@fernandezcuesta thanks for handling this! LGTM
Update generated webhook registration to match controller-runtime v0.20+ API
Description of your changes
Motivation: The controller-runtime library changed the
NewWebhookManagedByAPI. Prior to this change,provider-pagerduty(where I first found out this issue) generated by Upjet v2.2 fail to compile against current versions of controller-runtime.Relevant version upgrades (one leading to the other):
crossplane-runtimeto v2.2.0controller-runtimeto v0.23.3k8s.io/*v0.35.2Update the controller template to use the new
ctrl.NewWebhookManagedBy(mgr, object)signature, replacing the deprecatedctrl.NewWebhookManagedBy(mgr).For(object)builder pattern, as per controller-runtime documentation.No other issues found from controller-runtime v0.19.0 -> v0.23.1 (actually,
GetEventRecorderForin favor ofGetEventRecorderis blocked by crossplane-runtime).Also, due to the indirect upgrade to k8s.io/* to v0.35.0, test fake structs were annotated (
json: tagsannotations) to maintain compatibility.Fixes #604
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Built a rc for provider-pagerduty using these fixes, currently running with no issues in a staging cluster.