Skip to content

Fix parser_header failing for unicode OFX-2.x files without linebreaks. #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix parser_header failing for unicode OFX-2.x files without linebreaks. #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ofxtools/header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,8 @@ def parse_header(source: BinaryIO) -> Tuple[OFXHeaderType, str]:

# OFX header is read by nice clean machines, not meatbags -
# should not contain 💩, 漢字, or what have you.
line = source.readline().decode("ascii")
# However, the first line may contain the XML body, which CAN contain non-ascii.
line = source.readline().decode("ascii", "replace")
if line.strip():
found_header = True
break
Expand Down
10 changes: 10 additions & 0 deletions tests/test_header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,16 @@ def testParseHeaderV2NoNewlineBetweenHeaderAndBody(self):
self.assertIsNone(root.text)
self.assertEqual(len(root), 1)

def testParseHeaderV2NoNewlineBetweenHeaderAndBodyWithUnicode(self):
"""OFXv2 may contain non-ascii characters in the first line,
if the header is not separated from the body by newlines."""
ofxtools.header.parse_header(BytesIO(
b'<?xml version="1.0" encoding="utf-8" ?>'
b'<?OFX OFXHEADER="200" VERSION="202" SECURITY="NONE" OLDFILEUID="NONE" NEWFILEUID="NONE" ?>'
b'Dummy unicode data: A:\xc3\x83\xe2\x80\x9e\xc3\x83\xc2\xa4, '
b'O:\xc3\x83\xe2\x80\x93\xc3\x83\xc2\xb6, U:\xc3\x83\xc5\x93\xc3\x83\xc2\xbc, and SZ:\xc3\x83\xc5\xb8'
))

def testParseInvalid(self):
header = str(self.headerClass(self.defaultVersion))
with self.assertRaises(ofxtools.header.OFXHeaderError):
Expand Down