Open Recruitment page #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a tooltip to the recruitment link in the desktop navbar when it is marked as isWIP. This adds context for users who may be trying to access the recruitment information, but only see a greyed out button.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Check is failing, but I don't have access to the dashboard to see why @alexespejo 🫡 |
Contributor
Author
|
Also created with no design reference, I can ask Claire or others to sign off on design / accessibility |
This reverts commit ee9e6e8.
Contributor
Author
|
Opted to open the Recruitment page rather than use popup. Also changed:
Cleared with Claire, preferred over tooltip. |
alexespejo
requested changes
Nov 23, 2025
Member
alexespejo
left a comment
alexespejo
left a comment
There was a problem hiding this comment.
Smol change could merge and still work tho lol
|
|
||
| {navItems.map((item, index) => { | ||
| const isActive = pathname === item.href; | ||
| const isWIP = index >= navItems.length - 1; // Last two items |
Member
There was a problem hiding this comment.
Since we're just enabling the Recruitment page you can go ahead and remove the WIP flags. If there are any pages to be added I think they shouldn't be added to the nav bar till the page is finished
removed the WIP flag and associated styling as its no longer used now that the recruitment page has been implemented. Ready for review
theNatePi
deleted the
2-recruitment-navbar-link-is-disabled-with-no-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a tooltip to the recruitment link in the desktop navbar when it is marked as isWIP. This adds context for users who may be trying to access the recruitment information, but only see a greyed out button.
Closes #2