pkg/strconv: add ParseNum builtin #4139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose literal.ParseNum via pkg/strconv so CUE code can parse native number literals through the standard library. The wrapper returns an internal.Decimal and surfaces syntax issues as *strconv.NumError, matching the existing ParseInt/ParseFloat helpers. Signed-off-by: Carlos Jorge <[email protected]>
mvdan
approved these changes
Nov 11, 2025
Member
mvdan
left a comment
mvdan
left a comment
There was a problem hiding this comment.
Thanks! This looks fine from a first review. I'll import into Gerrit for a final review.
Member
|
Imported here: https://cue.gerrithub.io/c/cue-lang/cue/+/1226125 |
Member
|
Ended up renaming it to ParseNumber, for the sake of not shortening the name from the CUE spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose literal.ParseNum via pkg/strconv so CUE code can parse native number literals through the standard library. The wrapper returns an internal.Decimal and surfaces syntax issues as *strconv.NumError, matching the existing ParseInt/ParseFloat helpers.