Skip to content

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Sep 6, 2025

The new category shows all scopes that intersect with your current selection. Scopes smaller than the current selection are excluded and then sorted by smallest first. The result is that the scopes at the top are the ones that match your current selection the best. If you're ever interested in different ways of targeting a particular text you just need to select that and see which scopes match.

I'm not sure about the name/label. Any suggestions for something better than Selected?

image

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner September 6, 2025 11:22
@AndreasArvidsson AndreasArvidsson changed the title SelectedScopeVisualizer Added new selected category to scope visualizer Sep 6, 2025
@pokey
Copy link
Member

pokey commented Sep 6, 2025

Interesting idea. Could maybe be accomplished without adding a new section by just adding an emoji next to each scope description? Something like:

  • 🎯: scope exactly matches selection
  • 🪆: scope is strictly contained by selection
  • 📦: scope strictly contains selection
  • 🪢: scope has nonempty intersection with selection, but no containment either way

These could be combined if multiple apply (ie if your selection contains a function and is also contained by a function it would be 🪆📦)

I don't think sorting would be necessary because these would be really easy for your eye to pick up and then we preserve alphabetical

(Thanks to ChatGPT for help picking emojis ☺️)

@AndreasArvidsson
Copy link
Member Author

I'm not sure. My first thought was to have an icon like that, but then I start thinking that the sorting is actually quite useful.

@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Sep 7, 2025

Okay the latest version actually uses icons. Became a lot simpler. Note that I only use two separate icons.

🎯scope is equal to selection
📦 scope contains selection

I think the other two options are not really that useful and will just make things unnecessarily complicated

image

@AndreasArvidsson AndreasArvidsson changed the title Added new selected category to scope visualizer Add containment icons to scope visualizer Sep 7, 2025
@AndreasArvidsson AndreasArvidsson merged commit 8e0ddaf into main Sep 11, 2025
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the selectedScopeVisualizer branch September 11, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants