-
Notifications
You must be signed in to change notification settings - Fork 30
Lumino tab titles - distinguish between log view tabs #2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ac713cf
to
25b272e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good. I've made some style suggestions.
.lm-TabBar-tabLabel { | ||
font-family: settings.$body-font-family; | ||
font-size: 1rem; | ||
font-size: 0.9rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea is that 1rem
is the smallest font-size used on the page, i.e, this is supposed to define the lower-limit of readability.
Tested as working, looks good. I'm not sure if we want to close #2023 just yet though. I think we might want to go a bit further, e.g, we could use a symbol for the view type (saves a few chars) and use text-editor style path shortening to reduce tab title lengths as needed. |
Closes #2023
Distinguish between job and workflow log tabs in the tab title, and add a caption that shows the open file. It would be good to include that in the tab title but we would need to figure out how to truncate well.
Also increased the width of the tabs and reduced the font size slightly to accommodate the longer length of "Log − Workflow" as a title
Checklist
CONTRIBUTING.md
and added my name as a Code Contributor.