Skip to content

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Aug 26, 2025

Closes #2023

Distinguish between job and workflow log tabs in the tab title, and add a caption that shows the open file. It would be good to include that in the tab title but we would need to figure out how to truncate well.

Also increased the width of the tabs and reduced the font size slightly to accommodate the longer length of "Log − Workflow" as a title

image

Checklist

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Doc PR not needed

@MetRonnie MetRonnie added this to the 2.9.0 milestone Aug 26, 2025
@MetRonnie MetRonnie self-assigned this Aug 26, 2025
@MetRonnie MetRonnie added the UX/UI User experience and interface improvements label Aug 26, 2025
@MetRonnie MetRonnie changed the title Lumino tab titles Lumino tab titles - distinguish between log view tabs Aug 27, 2025
@MetRonnie MetRonnie modified the milestones: 2.9.0, 2.10.0 Sep 4, 2025
@MetRonnie MetRonnie requested a review from wxtim September 10, 2025 15:07
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good. I've made some style suggestions.

@oliver-sanders oliver-sanders modified the milestones: 2.10.0, 2.11.0 Sep 17, 2025
.lm-TabBar-tabLabel {
font-family: settings.$body-font-family;
font-size: 1rem;
font-size: 0.9rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea is that 1rem is the smallest font-size used on the page, i.e, this is supposed to define the lower-limit of readability.

@oliver-sanders
Copy link
Member

Tested as working, looks good.

I'm not sure if we want to close #2023 just yet though. I think we might want to go a bit further, e.g, we could use a symbol for the view type (saves a few chars) and use text-editor style path shortening to reduce tab title lengths as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UX/UI User experience and interface improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Distinguish multiple log view tabs

3 participants