-
Notifications
You must be signed in to change notification settings - Fork 21
CPU and Max RSS Analysis tools #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fixed bug with std dev calculation Added unit tests
# Conflicts: # cylc/uiserver/schema.py # cylc/uiserver/tests/test_workflow_retrieval.py
This comment was marked as resolved.
This comment was marked as resolved.
I've merged in the previous changes to the SQL infrastructure that deals with task states. @oliver-sanders I've had to change some of your code that creates parts of the SQL query, mostly just to take into account the new join. |
This comment was marked as resolved.
This comment was marked as resolved.
Code consistency Co-authored-by: Ronnie Dutta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes appear to have broken compatibility with workflows run in earlier versions of Cylc. I tested the tasks
GraphQL query on a workflow that ran in 8.4.4.dev and got an empty result
query {
tasks(live: false, workflows: ["wflow"]) {
name
}
}
{
"data": {
"tasks": []
}
}
This been fixed. Max RSS and CPU time will be 0, if no data is present. An update to the cylc-ui needs to be made to not show cpu time / max rss charts if there is no data |
# Conflicts: # cylc/uiserver/schema.py # cylc/uiserver/tests/test_workflow_retrieval.py
# Conflicts: # cylc/uiserver/schema.py
Is there a way to make this null instead of 0? Because currently the UI can't tell the difference between no data and times that are actually zero (to the nearest whole second). |
This apart of 3 pull requests for adding CPU time and Max RSS analysis to the Cylc UI.
This adds the Max RSS and CPU time (as measured by cgroups) to the table view, box plot and time series views.
Linked to;
cylc/cylc-flow#6663
cylc/cylc-ui#2100
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).?.?.x
branch.