-
Notifications
You must be signed in to change notification settings - Fork 396
feat: enable firefox arm64 build with cypress/factory #1307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable firefox arm64 build with cypress/factory #1307
Conversation
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
6d71074 to
8cfe1d3
Compare
|
@jennifer-shehane / @AtofStryker This PR is ready for review and merge. There is effectively no change for the This seems like a good addition. As a follow-up, documentation should be updated, however I don't think this PR should be held up waiting for documentation, as it is only an addition. Nothing is being lost. It also gives the opportunity to test with the released Cypress Docker images before updating the documentation. |
add firefox arm circleci tests
d51b5f8 to
cb30f9c
Compare
|
Re-based on Cypress |
AtofStryker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MikeMcC399 . Sorry for the delay in the review here. Just been a bit caught up with some other things. Everything looks good here. Going to merge in
Many thanks for reviewing and merging in! I will follow up with a documentation PR soon. |
arm64incypress/factorybuild #1306Situation
Until now, Cypress Docker images only had access to x86 versions of Firefox. The examples/firefox-esr additionally demonstrated how to build Firefox from the ESR (Extended Support Release) channel into a custom Cypress Docker image.
With the release of Firefox 136.0, Mozilla announced:
factory/installScripts/firefox skips installation if
x64is not detected. This prevents any attempt to install Firefox forarm64.Change
Modify scripts in factory/installScripts/firefox to allow installing Firefox
arm64in addition toamd64:CDN is
https://download-installer.cdn.mozilla.net/pub/firefox/releases/<version>/linux-x86_64/en-US/foramd64https://download-installer.cdn.mozilla.net/pub/firefox/releases/<version>/linux-aarch64/en-US/forarm64(new)This change is backwards-compatible with previous versions of Firefox.
Add Firefox arm tests to factory/test-project/docker-compose.yml. These tests could be made required in GitHub branch protection rules at a later stage.
In factory/.env make the following updates:
FACTORY_VERSION5.4.05.5.0FACTORY_DEFAULT_NODE_VERSION22.14.0CHROME_VERSION134.0.6998.88-1EDGE_VERSION134.0.3124.51-1FIREFOX_VERSION136.0.1Outcome
arm64architecture can contain Firefox>=136.0FIREFOX_VERSIONorFACTORY_DEFAULT_NODE_VERSIONis bumped in any future PR, any new Debian Linuxarm64Cypress Docker imagescypress/browsersandcypress/includedwill include Firefox