- 
                Notifications
    
You must be signed in to change notification settings  - Fork 3.4k
 
refactor: modernizes visibility tests #32833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
          
  cypress 
  
 | 
    ||||||||||||||||||||||||||||||||||||||||
| Project | 
          cypress
         | 
      
| Branch Review | 
          refactor/visibility-tests
         | 
      
| Run status | 
          
         | 
      
| Run duration | 16m 10s | 
      
| Commit | 
          
         | 
      
| Committer | Cacie Prins | 
      
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
| 
         | 
      
        0
       | 
    
| 
         | 
      
        0
       | 
    
| 
         | 
      
        11
       | 
    
| 
         | 
      
        0
       | 
    
| 
         | 
      
        636
       | 
    
| View all changes introduced in this branch ↗︎ | |
        UI Coverage
         0%
       | 
    |
|---|---|
| 
         | 
      
        4  
       | 
    
| 
         | 
      
        0  
       | 
    
        Accessibility
         100%
       | 
    |
|---|---|
| 
         | 
      
        0 critical  
        0 serious  
        0 moderate  
        0 minor
       | 
    
| 
         | 
      
        0  
       | 
    
              
                    ryanthemanuel
  
              
              approved these changes
              
                  
                    Oct 29, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Additional details
In preparation for testing visibility algorithm modifications, this refactors the
visibility.cy.tsspec. It now uses static html fixtures, and a declarative testing style that makes it easier to determine what should and should not be visible.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Rewrites DOM visibility tests to use static HTML fixtures with declarative expectations and shared helpers, expanding coverage across CSS, forms, overflow, positioning, transforms, and reason messages.
packages/driver/cypress/e2e/dom/visibility.cy.ts:assertVisibilityForEl,prepareFixtureSection,assertVisibilityForSectionsand groups tests into scenario suites.cy-expect/cy-legacy-expect.html/bodyoverrides and updates#getReasonIsHiddenassertions to read from fixtures.packages/driver/cypress/fixtures/visibility/:basic-css-properties.html,form-elements.html,overflow.html,positioning.html,transforms.html,empty.html,table-visibility.html.style.css(section visibility and highlighting) andux.js(in-page nav/section activation).Written by Cursor Bugbot for commit 4573e14. This will update automatically on new commits. Configure here.