- 
                Notifications
    
You must be signed in to change notification settings  - Fork 3.4k
 
chore: refactor server files to TypeScript #32838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          
  cypress 
  
 | 
    ||||||||||||||||||||||||||||||||||||||||
| Project | 
          cypress
         | 
      
| Branch Review | 
          chore/refactor_server_p2
         | 
      
| Run status | 
          
         | 
      
| Run duration | 43m 19s | 
      
| Commit | 
          
         | 
      
| Committer | Bill Glesias | 
      
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
| 
         | 
      
        1
       | 
    
| 
         | 
      
        10
       | 
    
| 
         | 
      
        1102
       | 
    
| 
         | 
      
        4
       | 
    
| 
         | 
      
        26625
       | 
    
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
        UI Coverage
         45.48%
       | 
    |
|---|---|
| 
         | 
      
        188  
       | 
    
| 
         | 
      
        161  
       | 
    
        Accessibility
         97.98%
       | 
    |
|---|---|
| 
         | 
      
        4 critical  
        8 serious  
        2 moderate  
        2 minor
       | 
    
| 
         | 
      
        101  
       | 
    
Tests for review
   cypress/e2e/commands/files.cy.js • 1 failed test • 5x-driver-firefox 
  dc5b886    to
    18c1405      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
| @@ -0,0 +1,88 @@ | |||
| // TODO: move this to packages/core-file-server | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this comment is relevant? This doesn't event exist.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Migrates server utilities and file server to TypeScript, updates random/env APIs and imports, integrates typed file server/HTTPS proxy, and adjusts tests accordingly.
file_server,util/env, andutil/terminal-sizefrom JS to TS; add typings forFileServerand HTTPS proxyServer.util/fileto TSFileclass with typed methods andnoopFile; update call sites (cache.ts,saved_state.ts, tests) to import{ File as FileUtil }.envimport with* as env; inutil/resolve.jsuseprocess.envdirectly.randomhelper to namedidexport and update usages across server (modes,run,cloud/auth, etc.).https-proxy/lib/index.ts, re-exporttype { Server }.server-base.tsto import* as fileServer, type cast_httpsProxyand_fileServer, and passfileServerFolderasstring.x-cypress-file-server-errorto'true', add@ts-expect-errornotes).print-run.beginUploadActivityOutputviaNumber(UPLOAD_ACTIVITY_INTERVAL).Fileexport; adjust random ID tests to userandomId.Written by Cursor Bugbot for commit 18c1405. This will update automatically on new commits. Configure here.