Skip to content

Add MySQL port, fixes #4 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add MySQL port, fixes #4 #5

wants to merge 2 commits into from

Conversation

lumbric
Copy link

@lumbric lumbric commented Aug 20, 2017 •
edited
Loading

I don't undestand why this ever worked before, but this fix seems to work for me. Also it is a nice thing to be able to select port via argument on CLI.

@lumbric lumbric mentioned this pull request Aug 20, 2017
Open
@skwashd
Copy link

skwashd commented Jun 4, 2018

While this fixes #4 it also contains a commit from #6. I have proposed #10 that fixes the port issue. To keep it consistent with the other values being concatenated into the string I used a pointer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lumbric @skwashd