Fix #11389 Do not warn for truncLongCastReturn if operands have known valid int

[ceJce]

This fix handles the first example in ticket, i.e. when the value is known to be a valid int:

long f() {
int n = 1;
return n << 12;
}

[danmar]

thanks! I would like some test cases. One case where we don't write a false positive.

And verify that we still warn when we want.

[ceJce]

thanks! I would like some test cases. One case where we don't write a false positive.

And verify that we still warn when we want.

Tests added.

[danmar]

I don't feel it's enough to just check if it's a known value. I feel we should check if it is a known value that fits in an int. I would still like to warn here:

long f() {
    unsigned int n = 1U << 20;
    return n << 20;
}

Can you please add a test where we do warn for such code.

[ceJce]

Fixed

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud