Skip to content

Fix #13944 FN constParameterPointer in method in derived class #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ceJce wants to merge 4 commits into
base: main
Choose a base branch
from
+41 −8
Open

Fix #13944 FN constParameterPointer in method in derived class #8240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c32577
Fix #13944: FN constParameterPointer in method in derived class
ceJce Feb 19, 2026
3a18138
Fix #13944 tests
ceJce Feb 19, 2026
81ef7f1
fix
ceJce Feb 19, 2026
f245c18
Updated according to findings
ceJce Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/checkother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1996,8 +1996,9 @@ void CheckOther::checkConstPointer()
nonConstPointers.emplace(var);
}
for (const Variable *p: pointers) {
bool inconclusive = false;
if (p->isArgument()) {
if (!p->scope() || !p->scope()->function || p->scope()->function->isImplicitlyVirtual(true) || p->scope()->function->hasVirtualSpecifier())
if (!p->scope() || !p->scope()->function || p->scope()->function->isImplicitlyVirtual(false, nullptr, &inconclusive) || p->scope()->function->hasVirtualSpecifier())
continue;
if (p->isMaybeUnused())
continue;
Expand All @@ -2014,12 +2015,12 @@ void CheckOther::checkConstPointer()
continue;
if (p->typeStartToken() && p->typeStartToken()->isSimplifiedTypedef() && !(Token::simpleMatch(p->typeEndToken(), "*") && !p->typeEndToken()->isSimplifiedTypedef()))
continue;
constVariableError(p, p->isArgument() ? p->scope()->function : nullptr);
constVariableError(p, p->isArgument() ? p->scope()->function : nullptr, &inconclusive);
}
}
}

void CheckOther::constVariableError(const Variable *var, const Function *function)
void CheckOther::constVariableError(const Variable *var, const Function *function, const bool *inconclusive)
{
if (!var) {
reportError(nullptr, Severity::style, "constParameter", "Parameter 'x' can be declared with const");
Expand All @@ -2038,7 +2039,9 @@ void CheckOther::constVariableError(const Variable *var, const Function *functio

ErrorPath errorPath;
std::string id = "const" + vartype;
std::string message = "$symbol:" + varname + "\n" + vartype + " '$symbol' can be declared as " + ptrRefArray;
std::string message = !(inconclusive && *inconclusive) ?
"$symbol:" + varname + "\n" + vartype + " '$symbol' can be declared as " + ptrRefArray :
"$symbol:" + varname + "\nEither there is missing override/final keyword, or the " + vartype + " '$symbol' can be " + ptrRefArray;
errorPath.emplace_back(var->nameToken(), message);
if (var->isArgument() && function && function->functionPointerUsage) {
errorPath.emplace_front(function->functionPointerUsage, "You might need to cast the function pointer here");
Expand Down
2 changes: 1 addition & 1 deletion lib/checkother.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ class CPPCHECKLIB CheckOther : public Check {
void suspiciousFloatingPointCastError(const Token *tok);
void invalidPointerCastError(const Token* tok, const std::string& from, const std::string& to, bool inconclusive, bool toIsInt);
void passedByValueError(const Variable* var, bool inconclusive, bool isRangeBasedFor = false);
void constVariableError(const Variable *var, const Function *function);
void constVariableError(const Variable *var, const Function *function, const bool *inconclusive = nullptr);
void constStatementError(const Token *tok, const std::string &type, bool inconclusive);
void signedCharArrayIndexError(const Token *tok);
void unknownSignCharArrayIndexError(const Token *tok);
Expand Down
9 changes: 7 additions & 2 deletions lib/symboldatabase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4810,8 +4810,10 @@ void Function::addArguments(const Scope *scope)
}
}

bool Function::isImplicitlyVirtual(bool defaultVal, bool* pFoundAllBaseClasses) const
bool Function::isImplicitlyVirtual(bool defaultVal, bool* pFoundAllBaseClasses, bool* inconclusive) const
{
if (inconclusive)
*inconclusive = false; // assume not inconclusive.
if (hasVirtualSpecifier() || hasOverrideSpecifier() || hasFinalSpecifier())
return true;
bool foundAllBaseClasses = true;
Expand All @@ -4821,7 +4823,10 @@ bool Function::isImplicitlyVirtual(bool defaultVal, bool* pFoundAllBaseClasses)
*pFoundAllBaseClasses = foundAllBaseClasses;
if (foundAllBaseClasses) //If we've seen all the base classes and none of the above were true then it must not be virtual
return false;
return defaultVal; //If we can't see all the bases classes then we can't say conclusively
//If we can't see all the bases classes then we can't say conclusively, set inconclusive (if possible) and return default value
Copy link
Collaborator

@chrchr-github chrchr-github Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't inconclusive redundant since there is pFoundAllBaseClasses already?

if (inconclusive)
*inconclusive = true;
return defaultVal;
}

std::vector<const Function*> Function::getOverloadedFunctions() const
Expand Down
2 changes: 1 addition & 1 deletion lib/symboldatabase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,7 @@ class CPPCHECKLIB Function {
void addArguments(const Scope *scope);

/** @brief check if this function is virtual in the base classes */
bool isImplicitlyVirtual(bool defaultVal = false, bool* pFoundAllBaseClasses = nullptr) const;
bool isImplicitlyVirtual(bool defaultVal = false, bool* pFoundAllBaseClasses = nullptr, bool* inconclusive = nullptr) const;

std::vector<const Function*> getOverloadedFunctions() const;

Expand Down
25 changes: 25 additions & 0 deletions test/testother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4676,6 +4676,31 @@ class TestOther : public TestFixture {
ASSERT_EQUALS("[test.cpp:1:18]: (style) Parameter 'p' can be declared as pointer to const [constParameterPointer]\n"
"[test.cpp:4:18]: (style) Parameter 'p' can be declared as pointer to const [constParameterPointer]\n",
errout_str());

check("class A {\n"
"public:\n"
" void func01(QPoint* pt1) {\n"
" if (nullptr == pt1) {}\n"
" }\n"
"};\n");
ASSERT_EQUALS("[test.cpp:3:25]: (style) Parameter 'pt1' can be declared as pointer to const [constParameterPointer]\n",
errout_str());

check("class A : public QObject {\n"
"public:\n"
" void func01(QPoint* pt2) {\n"
" if (nullptr == pt2) {}\n"
" }\n"
"};\n");
ASSERT_EQUALS("[test.cpp:3:25]: (style) Either there is missing override/final keyword, or the Parameter 'pt2' can be pointer to const [constParameterPointer]\n",
errout_str());
check("class A : public QObject {\n"
"public:\n"
" void func01(QPoint* pt3) override {\n"
" if (nullptr == pt3) {}\n"
" }\n"
"};\n");
ASSERT_EQUALS("", errout_str());
}

void constArray() {
Expand Down
Loading