Skip to content

do not add empty filename to files in preprocess()#350

Merged
danmar merged 2 commits intodanmar:masterfrom
firewave:macro-files
Apr 23, 2024
Merged

do not add empty filename to files in preprocess()#350
danmar merged 2 commits intodanmar:masterfrom
firewave:macro-files

Conversation

@firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

Required for danmar/cppcheck#6326.

Not sure if a test can be written for this.

@firewave
Copy link
Collaborator Author

Made a draft because the downstream PR which is built upon these changes fails.

@firewave
Copy link
Collaborator Author

Made a draft because the downstream PR which is built upon these changes fails.

Turns out that it was a fluke.

@firewave firewave marked this pull request as ready for review April 22, 2024 18:52
@firewave firewave marked this pull request as draft April 22, 2024 19:41
@firewave
Copy link
Collaborator Author

I will still add a unit test for this.

@firewave
Copy link
Collaborator Author

I will still add a unit test for this.

Done.

@firewave firewave marked this pull request as ready for review April 23, 2024 09:31
@danmar danmar merged commit 19df0b1 into danmar:master Apr 23, 2024
@firewave firewave deleted the macro-files branch April 23, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments