Skip to content

test: add rest of quickstarts plus wip starting with 05 ones #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 17, 2025
Merged

test: add rest of quickstarts plus wip starting with 05 ones #272

merged 13 commits into from
Nov 17, 2025

Conversation

@sicoyle
Copy link
Collaborator

@sicoyle sicoyle commented Nov 12, 2025 •
edited
Loading

WIP adding automation to the rest of the quickstarts. I'm working through issues with the more complicated ones like the 05 one rn.

  1. This PR adds automation for the remaining quickstarts using the comment of "/ok-to-test" in our PRs.
  2. For the 05 quickstart, I had to create a different registry per orchestrator so the apps (being the same) could all fall under a diff team for the quickstart tests to run without picking up on the other orchestrators. I added an env var for this to override which registry store to use in the tests.

@sicoyle
test: add rest of quickstarts plus wip starting with 05 ones
8400b79 
Signed-off-by: Samantha Coyle <[email protected]>
@sicoyle
fix: update so rest of tests work
dd09531 
Signed-off-by: Samantha Coyle <[email protected]>
@sicoyle
fix: tox -e ruff
e62f8ed 
Signed-off-by: Samantha Coyle <[email protected]>
@sicoyle
style: stream all logs by default for starters
2cae1af 
Signed-off-by: Samantha Coyle <[email protected]>
@sicoyle
style: appease flake8:
ea747ad 
Signed-off-by: Samantha Coyle <[email protected]>
@sicoyle
fix: run all int tests in ci wf
d646710 
Signed-off-by: Samantha Coyle <[email protected]>
@sicoyle
style: tox -e ruff
d15c696 
Signed-off-by: Samantha Coyle <[email protected]>
@sicoyle
style: use helpers
8c002c9 
Signed-off-by: Samantha Coyle <[email protected]>
@sicoyle
style: update comments
89abe1b 
Signed-off-by: Samantha Coyle <[email protected]>
@sicoyle sicoyle marked this pull request as ready for review November 12, 2025 22:12
Cyb3rWard0g
Cyb3rWard0g previously approved these changes Nov 14, 2025
View reviewed changes
Copy link
Collaborator

@Cyb3rWard0g Cyb3rWard0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yaron2
yaron2 previously approved these changes Nov 14, 2025
View reviewed changes
@sicoyle
fix: rm pr req check
59bf1c3 
Signed-off-by: Samantha Coyle <[email protected]>
@sicoyle sicoyle dismissed stale reviews from yaron2 and Cyb3rWard0g via 59bf1c3 November 17, 2025 16:41
@sicoyle
Copy link
Collaborator Author

sicoyle commented Nov 17, 2025

/ok-to-test

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Integration Tests Summary

Python Version Status
3.10 ❌ FAILED
3.11 ❌ FAILED
3.12 ❌ FAILED
3.13 ❌ FAILED

Overall Status: ❌ Some tests failed
Workflow: View run

@yaron2 yaron2 merged commit a04efb7 into dapr:main Nov 17, 2025
6 checks passed
@sicoyle sicoyle deleted the test/feat-enable-ci-for-rest-of-quickstarts branch November 17, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaron2 yaron2 yaron2 approved these changes

@Cyb3rWard0g Cyb3rWard0g Cyb3rWard0g left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sicoyle @Cyb3rWard0g @yaron2