Remaining work on RCD, LMMSE and PPG demosaicers#20640
Open
jenshannoschwalm wants to merge 1 commit intodarktable-org:masterfrom
Open
Remaining work on RCD, LMMSE and PPG demosaicers#20640jenshannoschwalm wants to merge 1 commit intodarktable-org:masterfrom
jenshannoschwalm wants to merge 1 commit intodarktable-org:masterfrom
Conversation
1. To avoid border remaining CPU/GPU differences we have to increase the outermost margin to 9 as we did for the border 2. As the RCD-internal border algorithms was basically a PPG variant that code got deduplicated and we have that now all in ppg code. 3. Also some PPG CPU/GPU differences got fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TurboGit there are further changes in expected output as for RCD the CPU border code was still wrong and in PPG we have subtle differences but those are correct now.
Overall, together with #20639 and #20631 this was the round of demosaicer related finetuning & fixes. checked integration tests with all three and couldn't spot any unexpected/bad results.
Currently we have