Enable language version 3.10 and format dot shorthands. #1745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is using a workaround for dart-lang/sdk#60840. That issue is fixed and a new version of analyzer is published, but unfortunately there is no corresponding version of test that works with it so I can't upgrade yet. The workaround is pretty harmless, so I'm fine with it. (The formatter uses similar logic to handle commas which also aren't represented in the AST nodes.)
natebosch
approved these changes
Jul 18, 2025
munificent
added a commit
that referenced
this pull request
Jul 18, 2025
The only change in this version is allowing 3.9 as a supported language version. This was rolled into the SDK a couple of weeks ago, but not published. I figure I should publish this before rolling the supported version again to 3.10 just in case any external needs 3.9 support. I'll land this before landing #1745.
munificent
added a commit
that referenced
this pull request
Jul 18, 2025
The only change in this version is allowing 3.9 as a supported language version. This was rolled into the SDK a couple of weeks ago, but not published. I figure I should publish this before rolling the supported version again to 3.10 just in case any external needs 3.9 support. I'll land this before landing #1745.
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
kallentu
reviewed
Jul 18, 2025
I just tried that and it looks like there are a decent number of changes I'll have to make to get things working with 8.0.0, so I'll probably land the workaround for now and then update to 8.0.0 when the new test version is out. |
|
Actually, it turns out the changes were trivial so I'll sit on this PR until the new test version is out and then upload a commit that bumps to 8.0.0. |
|
OK, I updated to the latest analyzer and removed the workarounds now that the AST has everything I need. PTAL, thanks! |
natebosch
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is using a workaround for dart-lang/sdk#60840. That issue is fixed and a new version of analyzer is published, but unfortunately there is no corresponding version of test that works with it so I can't upgrade yet.
The workaround is pretty harmless, so I'm fine with it. (The formatter uses similar logic to handle commas which also aren't represented in the AST nodes.)
I pulled the tests here by looking at the language tests for the feature (which are excellent and comprehensive) so I think I covered everything. I verified that the formatter can format everything in the SDK language tests (at least everything that can be parsed because there are error tests in there). Let me know if you see any corners of the syntax I missed. (I didn't realize that you could use
constuntil I read the tests.)Fix #1686.