-
Notifications
You must be signed in to change notification settings - Fork 220
Revise the declaring/primary constructor proposal #4480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anguage meeting yesterday
munificent
approved these changes
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! I agree the scoping is unusual. But it's consistent with initializer lists and those seem to have done the right thing in practice for years without user complaint.
lrhn
approved these changes
Aug 7, 2025
Thanks for great reviews! More changes are coming tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the declaring/primary constructor proposal to use a different scoping structure, to clarify the placement of the modifier
const
with a declaring constructor, to mention the principle that the class header should contain all parts of the signature of a declaring constructor if it contains any of them (e.g.,class const C();
makes the primary constructor constant, but we can't doclass C() { const this; }
). Moreover, this PR includes several other minor clarifications and corrections.