Skip to content

WIP - just experimenting #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions pkgs/code_assets/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,20 +1 @@
include: package:dart_flutter_team_lints/analysis_options.yaml

analyzer:
language:
strict-raw-types: true
plugins:
# - custom_lint # https://github.com/dart-lang/sdk/issues/60784

linter:
rules:
- avoid_positional_boolean_parameters
- public_member_api_docs
- prefer_const_declarations
- prefer_expression_function_bodies
- prefer_final_in_for_each
- prefer_final_locals

custom_lint:
rules:
- avoid_import_outside_src
include: package:native_test_helpers/analysis_options.yaml
4 changes: 0 additions & 4 deletions pkgs/code_assets/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,7 @@ dependencies:
hooks: ^0.19.5

dev_dependencies:
custom_lint: ^0.7.5
dart_flutter_team_lints: ^3.5.2
json_schema: ^5.2.0 # May only be used in tool/ and test/json_schema/.
native_test_helpers:
path: ../native_test_helpers/
repo_lint_rules:
path: ../repo_lint_rules/
test: ^1.25.15
20 changes: 1 addition & 19 deletions pkgs/data_assets/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,19 +1 @@
include: package:dart_flutter_team_lints/analysis_options.yaml

analyzer:
language:
strict-raw-types: true
plugins:
# - custom_lint # https://github.com/dart-lang/sdk/issues/60784

linter:
rules:
- avoid_positional_boolean_parameters
- prefer_const_declarations
- prefer_expression_function_bodies
- prefer_final_in_for_each
- prefer_final_locals

custom_lint:
rules:
- avoid_import_outside_src
include: package:native_test_helpers/analysis_options.yaml
4 changes: 0 additions & 4 deletions pkgs/data_assets/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,7 @@ dependencies:
hooks: ^0.19.5

dev_dependencies:
custom_lint: ^0.7.5
dart_flutter_team_lints: ^3.5.2
json_schema: ^5.2.0 # May only be used in tool/ and test/json_schema/.
native_test_helpers:
path: ../native_test_helpers
repo_lint_rules:
path: ../repo_lint_rules/
test: ^1.25.15
10 changes: 1 addition & 9 deletions pkgs/ffi/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1 @@
include: package:dart_flutter_team_lints/analysis_options.yaml

analyzer:
language:
strict-raw-types: true

linter:
rules:
- prefer_final_locals
include: package:native_test_helpers/analysis_options.yaml
3 changes: 2 additions & 1 deletion pkgs/ffi/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@ environment:
sdk: '>=3.7.0 <4.0.0'

dev_dependencies:
dart_flutter_team_lints: ^3.5.2
native_test_helpers:
path: ../native_test_helpers
test: ^1.21.2
24 changes: 1 addition & 23 deletions pkgs/ffigen/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,23 +1 @@
# Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.

include: package:dart_flutter_team_lints/analysis_options.yaml

analyzer:
exclude:
- 'test/**_expected*'

# Exclude anything that uses package:objective_c, due to flutter dependency.
# https://github.com/dart-lang/native/issues/1068
- example/objective_c/**
- example/swift/**
- test_flutter/native_objc_test/**
- test/native_objc_test/**
language:
strict-raw-types: true

linter:
rules:
prefer_final_locals: true
prefer_final_in_for_each: true
include: package:native_test_helpers/analysis_options.yaml
1 change: 0 additions & 1 deletion pkgs/ffigen/example/c_json/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,5 @@ dependencies:
path: ^1.8.0

dev_dependencies:
dart_flutter_team_lints: ^3.5.2
ffigen:
path: '../../'
1 change: 0 additions & 1 deletion pkgs/ffigen/example/ffinative/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,5 @@ dependencies:
ffi: ^2.0.1

dev_dependencies:
dart_flutter_team_lints: ^3.5.2
ffigen:
path: '../../'
1 change: 0 additions & 1 deletion pkgs/ffigen/example/libclang-example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,5 @@ dependencies:
ffi: ^2.0.1

dev_dependencies:
dart_flutter_team_lints: ^3.5.2
ffigen:
path: '../../'
1 change: 0 additions & 1 deletion pkgs/ffigen/example/objective_c/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ dependencies:
objective_c: ^0.0.1

dev_dependencies:
dart_flutter_team_lints: ^3.5.2
ffigen:
path: ../../

Expand Down
1 change: 0 additions & 1 deletion pkgs/ffigen/example/shared_bindings/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,5 @@ dependencies:
path: ^1.8.0

dev_dependencies:
dart_flutter_team_lints: ^3.5.2
ffigen:
path: '../../'
1 change: 0 additions & 1 deletion pkgs/ffigen/example/simple/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,5 @@ dependencies:
ffi: ^2.0.1

dev_dependencies:
dart_flutter_team_lints: ^3.5.2
ffigen:
path: '../../'
1 change: 0 additions & 1 deletion pkgs/ffigen/example/swift/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ dependencies:
objective_c: ^0.0.1

dev_dependencies:
dart_flutter_team_lints: ^3.5.2
ffigen:
path: ../../

Expand Down
3 changes: 2 additions & 1 deletion pkgs/ffigen/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ dependencies:

dev_dependencies:
async: ^2.11.0
dart_flutter_team_lints: ^3.5.2
native_test_helpers:
path: ../native_test_helpers
json_schema: ^5.1.1
leak_tracker: ^10.0.7
objective_c: ^8.1.0
Expand Down
21 changes: 1 addition & 20 deletions pkgs/hooks/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,20 +1 @@
include: package:dart_flutter_team_lints/analysis_options.yaml

analyzer:
language:
strict-raw-types: true
plugins:
# - custom_lint # https://github.com/dart-lang/sdk/issues/60784

linter:
rules:
- avoid_positional_boolean_parameters
- public_member_api_docs
- prefer_const_declarations
- prefer_expression_function_bodies
- prefer_final_in_for_each
- prefer_final_locals

custom_lint:
rules:
- avoid_import_outside_src
include: package:native_test_helpers/analysis_options.yaml
1 change: 0 additions & 1 deletion pkgs/hooks/example/build/download_asset/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ dependencies:
dev_dependencies:
args: ^2.6.0
ffigen: ^18.0.0
lints: ^6.0.0
test: ^1.25.15

# Note: If pub workspaces are in use, the user-defines must be in the workspace
Expand Down
1 change: 0 additions & 1 deletion pkgs/hooks/example/build/local_asset/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,4 @@ dependencies:
dev_dependencies:
ffigen: ^18.0.0
file_testing: ^3.0.2
lints: ^6.0.0
test: ^1.25.15
1 change: 0 additions & 1 deletion pkgs/hooks/example/build/native_add_app/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,4 @@ dependencies:
path: ../native_add_library/

dev_dependencies:
lints: ^6.0.0
test: ^1.25.15
1 change: 0 additions & 1 deletion pkgs/hooks/example/build/native_add_library/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,4 @@ dependencies:

dev_dependencies:
ffigen: ^18.0.0
lints: ^6.0.0
test: ^1.25.15
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,4 @@ dependencies:

dev_dependencies:
ffigen: ^18.0.0
lints: ^6.0.0
test: ^1.25.15
1 change: 0 additions & 1 deletion pkgs/hooks/example/build/system_library/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@ dependencies:

dev_dependencies:
ffigen: ^18.0.0
lints: ^6.0.0
test: ^1.25.15
1 change: 0 additions & 1 deletion pkgs/hooks/example/build/use_dart_api/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@ dependencies:

dev_dependencies:
ffigen: ^18.0.0
lints: ^6.0.0
test: ^1.25.15
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include: package:lints/recommended.yaml
include: package:native_test_helpers/analysis_options.yaml

# For additional information about configuring this file, see
# Additional information about this file can be found at
# https://dart.dev/guides/language/analysis-options
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,4 @@ dependencies:
path: ../package_with_assets/

dev_dependencies:
lints: ^6.0.0
test: ^1.25.15
1 change: 0 additions & 1 deletion pkgs/hooks/example/link/package_with_assets/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@ dependencies:
record_use: ^0.3.0

dev_dependencies:
lints: ^6.0.0
test: ^1.25.15
4 changes: 0 additions & 4 deletions pkgs/hooks/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ dependencies:
dev_dependencies:
args: ^2.6.0
code_assets: ^0.19.4 # Used for running tests with real asset types.
custom_lint: ^0.7.5
dart_flutter_team_lints: ^3.5.2
data_assets: any # Used for running tests with real asset types.
file_testing: ^3.0.2
glob: any
Expand All @@ -41,6 +39,4 @@ dev_dependencies:
native_test_helpers:
path: ../native_test_helpers/
path: ^1.9.1
repo_lint_rules:
path: ../repo_lint_rules/
test: ^1.25.15
20 changes: 1 addition & 19 deletions pkgs/hooks_runner/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,19 +1 @@
include: package:dart_flutter_team_lints/analysis_options.yaml

analyzer:
language:
strict-raw-types: true
plugins:
# - custom_lint # https://github.com/dart-lang/sdk/issues/60784

linter:
rules:
- avoid_positional_boolean_parameters
- prefer_const_declarations
- prefer_expression_function_bodies
- prefer_final_in_for_each
- prefer_final_locals

custom_lint:
rules:
- avoid_import_outside_src
include: package:native_test_helpers/analysis_options.yaml
4 changes: 0 additions & 4 deletions pkgs/hooks_runner/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,8 @@ dependencies:
yaml: ^3.1.3

dev_dependencies:
custom_lint: ^0.7.5
dart_flutter_team_lints: ^3.5.2
data_assets: any # Used in tests.
file_testing: ^3.0.2
native_test_helpers:
path: ../native_test_helpers/
repo_lint_rules:
path: ../repo_lint_rules/
test: ^1.25.15
1 change: 0 additions & 1 deletion pkgs/hooks_runner/test_data/add_asset_link/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@ dependencies:
native_toolchain_c: any

dev_dependencies:
lints: ^6.0.0
test: ^1.25.15
1 change: 0 additions & 1 deletion pkgs/hooks_runner/test_data/complex_link/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,5 @@ dependencies:
logging: ^1.3.0

dev_dependencies:
lints: ^6.0.0
path: ^1.9.0
test: ^1.25.15
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,5 @@ dependencies:
logging: ^1.3.0

dev_dependencies:
lints: ^6.0.0
path: ^1.9.0
test: ^1.25.15
1 change: 0 additions & 1 deletion pkgs/hooks_runner/test_data/cyclic_package_1/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,3 @@ dependencies:
hooks: any

dev_dependencies:
lints: ^6.0.0
1 change: 0 additions & 1 deletion pkgs/hooks_runner/test_data/cyclic_package_2/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,3 @@ dependencies:
hooks: any

dev_dependencies:
lints: ^6.0.0
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,4 @@ dependencies:

dev_dependencies:
ffigen: ^18.0.0
lints: ^6.0.0
test: ^1.25.15
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,4 @@ dependencies:

dev_dependencies:
ffigen: ^18.0.0
lints: ^6.0.0
test: ^1.25.15
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ dependencies: {}

dev_dependencies:
ffigen: ^18.0.0
lints: ^6.0.0
native_add:
path: ../native_add/
test: ^1.25.15
1 change: 0 additions & 1 deletion pkgs/hooks_runner/test_data/drop_dylib_link/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,4 @@ dependencies:
native_toolchain_c: any

dev_dependencies:
lints: ^6.0.0
test: ^1.25.15
1 change: 0 additions & 1 deletion pkgs/hooks_runner/test_data/fail_build/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,4 @@ dependencies:

dev_dependencies:
ffigen: ^18.0.0
lints: ^6.0.0
test: ^1.25.15
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,4 @@ dependencies:

dev_dependencies:
ffigen: ^18.0.0
lints: ^6.0.0
test: ^1.25.15
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@ dependencies:

dev_dependencies:
ffigen: ^18.0.0
lints: ^6.0.0
test: ^1.25.15
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,4 @@ dependencies:

dev_dependencies:
ffigen: ^18.0.0
lints: ^6.0.0
test: ^1.25.15
1 change: 0 additions & 1 deletion pkgs/hooks_runner/test_data/infra_failure/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,4 @@ dependencies:

dev_dependencies:
ffigen: ^18.0.0
lints: ^6.0.0
test: ^1.25.15
Loading
Loading