-
Notifications
You must be signed in to change notification settings - Fork 75
WIP: [objective_c] Experimenting with isolate group shared #2444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
liamappelbe
wants to merge
35
commits into
main
Choose a base branch
from
objc_isolate_group_shared
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package:ffigen
package:objective_c
package:swiftgen
type-infra
A repository infrastructure change or enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on native assets migration, so that tests can be run in pure Dart: #2329
I'm currently trying to get block_test.dart to pass. To experiment with it yourself, check out this branch, navigate to the pkgs/ffigen directory, then run:
After that you can just run that last command to rerun the test. If you manually edit the bindings (in block_bindings.dart) make sure not to rerun the ffigen command, because your changes will be overwritten.
Most of the test is commented out. The one I'm working on is
'Listener block same thread'
. It passes, but the test doesn't terminate. Not sure why yet.