Skip to content

[native_doc_dartifier] Fix CI #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

marshelino-maged
Copy link
Contributor

closes #2471
CI output marshelino-maged#11

Adding an example in the "translate prompt" on how to translate "implementing an interface"

Before this small edit, the tests passed only 6 out of 10 times.
After the edit, they now pass 10 out of 10 times.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Copy link

github-actions bot commented Aug 4, 2025

PR Health

Changelog Entry
Package Changed Files
package:native_doc_dartifier pkgs/native_doc_dartifier/lib/src/prompts.dart

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/native_doc_dartifier/lib/native_doc_dartifier.dart
pkgs/native_doc_dartifier/lib/src/native_doc_dartifier_base.dart
pkgs/native_doc_dartifier/tool/compile_java.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@@ -76,7 +76,8 @@ JNIgen handles various syntactic and semantic differences between Java/Kotlin an
* Pass each interface method as a named closure argument within the `\$InterfaceName` factory constructor.
* Example: `InterfaceName.implement(\$InterfaceName(method1: (param1) { /* ... */ }))`
* **Reusable Implementations:**
* If the Java/Kotlin code defines a class that `implements` an interface, To translate it to Dart make this class to be 'final class with' \$InterfaceName, as JNIgen make a mixin class \$InterfaceName that handles this, Don't make it to implements InterfaceName only use the mixin class.
* If the Java/Kotlin code defines a class that `implements` an interface, To translate it to Dart make this class to be 'final class with', Don't make it to implements InterfaceName only use the mixin class.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also mention that to use this interface you'd need to do Comparable.implement(MyClass())

@HosseinYousefi HosseinYousefi merged commit 89f91be into dart-lang:main Aug 5, 2025
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native_doc_dartifier] CI issue
2 participants