Track only visible packages as dependency in the search index. #8863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Jul 25, 2025
isoos
commented
- summary.allDependencies include dev_dependencies pana#1167 (side comment)
- I don't think this has caused any issue yet, but it is better for consistency.
sigurdm
approved these changes
Aug 5, 2025
Agreed on that, and also for yesterday's issue: we need to have a better testing story for the search index building process: it is long-running, the visibility of items may change while it is running, and it should be able to handle it, but we don't have such tests - yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.