Update highlight.js download instructions and resources. #8864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Aug 5, 2025
| .hljs-char.escape_, | ||
| .hljs-link, | ||
| .hljs-params, | ||
| .hljs-property, | ||
| .hljs-punctuation, | ||
| .hljs-tag { | ||
| /* purposely ignored */ | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Missing newline at end of file
sigurdm
reviewed
Aug 5, 2025
third_party/highlight/github.css
Outdated
| .hljs-tag { | ||
| /* purposely ignored */ | ||
|
|
||
| } |
sigurdm
reviewed
Aug 5, 2025
| @@ -1,3 +1,11 @@ | |||
| pre code.hljs { | |||
There was a problem hiding this comment.
Are there visual changes associated with this?
There was a problem hiding this comment.
Generated before-after screenshots and compared them, the only visible difference seems to be a 1-2 pixels change in the code block's overall height (or rather a change in its bottom margin's size). It doesn't really affect the layout in any other way, I don't think it is important to counter it.
sigurdm
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.