new command pub cache gc
#4684
Open
new command pub cache gc
#4684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szakarias
approved these changes
Oct 7, 2025
| parts[parts.length - 1] == 'package_config.json') { | ||
| projectDir = p.joinAll(parts.sublist(0, parts.length - 2)); | ||
| } | ||
| log.message('* $projectDir'); |
Contributor
There was a problem hiding this comment.
Maybe restrict the number of outputs here?
Co-authored-by: Sarah Zakarias <[email protected]>
Co-authored-by: Sarah Zakarias <[email protected]>
jonasfj
reviewed
Nov 14, 2025
| hideNegatedUsage: true, | ||
| ); | ||
| argParser.addFlag( | ||
| 'ignore-timestamp', |
Member
There was a problem hiding this comment.
Suggested change
| 'ignore-timestamp', | |
| 'ignore-age', |
or maybe:
Suggested change
| 'ignore-timestamp', | |
| 'no-ignore-recent', |
or
Suggested change
| 'ignore-timestamp', | |
| 'no-skip-recent', |
or
Suggested change
| 'ignore-timestamp', | |
| 'no-keep-recent', |
or (not that I like it)
Suggested change
| 'ignore-timestamp', | |
| 'collect-recent', |
jonasfj
reviewed
Nov 14, 2025
Comment on lines
+43
to
+73
| final activeRoots = cache.activeRoots(); | ||
| final validActiveRoots = <String>[]; | ||
| final paths = <String>{}; | ||
| for (final packageConfigPath in activeRoots) { | ||
| late final PackageConfig packageConfig; | ||
| try { | ||
| packageConfig = PackageConfig.fromJson( | ||
| json.decode(readTextFile(packageConfigPath)), | ||
| ); | ||
| } on IOException catch (e) { | ||
| // Failed to read file - probably got deleted. | ||
| log.fine('Failed to read packageConfig $packageConfigPath: $e'); | ||
| continue; | ||
| } on FormatException catch (e) { | ||
| log.warning( | ||
| 'Failed to decode packageConfig $packageConfigPath: $e.\n' | ||
| 'It could be corrupted', | ||
| ); | ||
| // Failed to decode - probably corrupted. | ||
| continue; | ||
| } | ||
| for (final package in packageConfig.packages) { | ||
| final rootUri = p.canonicalize( | ||
| package.resolvedRootDir(packageConfigPath), | ||
| ); | ||
| if (p.isWithin(cache.rootDir, rootUri)) { | ||
| paths.add(rootUri); | ||
| } | ||
| } | ||
| validActiveRoots.add(packageConfigPath); | ||
| } |
Member
There was a problem hiding this comment.
Maybe, give the reader a two line comment, explaining what you are collecting into validActiveRoots and path.
Or maybe split it into a function.
jonasfj
reviewed
Nov 14, 2025
|
|
||
| final dontRemoveFilesOlderThan = const Duration(hours: 2); | ||
|
|
||
| CacheGcCommand() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To recover space occupied by unused old dependencies in the pub cache, without affecting "active" projects.
Will enumerate all package configs from all active projects to find all the packages located within the pub cache.
Then enumerates all packages/git repos in the pub cache, and removes those that are not referred to by the active projects.
Active projects have been marked since dart 3.9.0.