Rewrite inject_dartpad and expose some functionality in library #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also plan to use this new support in the Jaspr version of the docs site, rather than the prebuilt script. Once that is complete, I'll remove the pre-built JS and surrounding compilation support. |
johnpryan
reviewed
Sep 22, 2025
| /// | ||
| /// This ID is used both as the HTML element `id` and | ||
| /// as the iframe's `name` attribute for message targeting. | ||
| final String iframeId; |
There was a problem hiding this comment.
This makes it seem like the user needs to put an iframe on the page, but my understanding is that this needs to be a <code> element, right? Maybe we should make this just elementId if that's the case.
johnpryan
reviewed
Sep 22, 2025
| host.appendChild(iframe); | ||
| parent.replaceWith(host); | ||
| await embeddedDartPad.initialize( | ||
| addToDocument: (iframe) { |
There was a problem hiding this comment.
maybe this should be named "onElementCreated" or similar
antfitch
pushed a commit
to dart-lang/site-www
that referenced
this pull request
Sep 25, 2025
The `inject_dartpad.dart.js` script needs to be inlined now that site-shared is not a submodule. However, this is temporary as we plan to replace this with a new Dart API directly from a Jaspr component. The API is added in dart-lang/site-shared#247.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
web/inject_dartpad.dartwas just written as a script for dart.dev and docs.flutter.dev, but the logic wasn't really reusable in other contexts and didn't have much error handling. This PR rewrites and moves the core logic into a new library and class atlib/inject_dartpad.dartthat other clients can take advantage of through using this package as a git dependency.Besides being a public library, the new library also makes a few improvements over the original script.
jsifywith directly constructing the appropriate JS object.The script in
web/inject_dartpad.dartwas then updated to use the new library, with a few additional improvements:\cc @craiglabenz Since I can't assign you as a reviewer. I guess you don't have write access to this repo.