BUG: Fix delegation behaivour with atleast_3d.
#514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
reviewed
Nov 7, 2025
Member
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I wonder whether, rather than checking for exact equality in all of these tests, we should just check for expected shapes? Probably good to still keep one sanity-check test that we aren't unexpectedly modifying the values, but otherwise the tests are quite verbose.
Thoughts @Enderdead ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bad behavior reported in scipy/scipy#23929 when
ndim=3.It removes delegation when
ndim> 2 and adds additional tests.These tests reproduce the issue while avoiding input arrays of size 1.
I'm not entirely happy with these new tests, but they provide a reasonable starting point for further iteration.
Feedback is welcome.