Translate alert file_path to workspace path#4712
Closed
shreyas-goenka wants to merge 1 commit intomainfrom
Closed
Conversation
The alert resource's `file_path` field was not being translated to a workspace file path by the `TranslatePaths` mutator. This adds support for translating it, similar to how other path-based resources (notebooks, SQL files, etc.) are handled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 7066821
21 interesting tests: 7 SKIP, 6 RECOVERED, 4 flaky, 3 BUG, 1 KNOWN
Top 21 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file_pathfield in theTranslatePathsmutatorTranslateModeLocalRelativetoTranslateModeFile, so the.dbalert.jsonfile path is translated to a full workspace file path (e.g.,/Workspace/Users/.../.bundle/name/target/files/src/alert.dbalert.json)Test plan
VisitAlertPathsvisitorTranslatePathsAlertstranslationbundle/paths/alerts_file_paththat verifies thefile_pathis translated to a workspace pathmake test,make lintfull,make checks)🤖 Generated with Claude Code